Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index 

On 11/09/2015 08:17 PM, Christian Lohmaier wrote:

On Mon, Nov 9, 2015 at 6:00 PM, jan iversen <jani@documentfoundation.org> wrote:

Sometimes I have to correct an older patch set, I do the following in core:

git pull



<cherry pick gerrit patch set>


This is not only correcting an older patch set, but would also rebase it.
Not that this would be a bad thing, but it is doing more than fixing a
typo or similar.
It typically /is/ a bad thing if you then push the result as a new version of an existing gerrit change (which is presumably what the ./logerrit step does; I don't know anything about that script). It prevents meaningful diffs between different versions of a gerrit change.

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.