Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


Hi Łukasz,

On Saturday, 2015-10-10 13:47:33 +0200, Łukasz Hryniuk wrote:

Where can I start? You showed me some code during the Hackfest, but I don't
remember what it was exactly. Is ScOutputData::LayoutStrings in
sc/source/ui/view/output2.cxx the right place?

So I dug into that, and while LayoutStrings() looks like a logical place
to obtain the information, it is not the right place to do so.. ;) for
the reason that it actually should really only obtain the strings to be
drawn, which may involve recalculation etc. Stuffing all sorts of checks
in there isn't good, because when scrolling through the document the
information is not of interest until the user stops scrolling. Doing
additional checks would just slow down scrolling.

The checks should be triggered only if the view is "stable" and no user
input pending. Take a look at sc/source/ui/app/scmod.cxx the IdleHandler
and SpellTimerHdl, things should be similar to the spell check handling
and how it is done in ScGridWindow::ContinueOnlineSpelling()

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack

Attachment: signature.asc
Description: PGP signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.