New Defects reported by Coverity Scan for LibreOffice

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
8 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1321600:  Null pointer dereferences  (REVERSE_INULL)
/filter/source/msfilter/svdfppt.cxx: 2558 in SdrPowerPointImport::GetColorFromPalette(unsigned 
short, Color &) const()


________________________________________________________________________________________________________
*** CID 1321600:  Null pointer dereferences  (REVERSE_INULL)
/filter/source/msfilter/svdfppt.cxx: 2558 in SdrPowerPointImport::GetColorFromPalette(unsigned 
short, Color &) const()
2552                             if ( nMasterNum < pPageList2->size() )
2553                                 pMasterPersist = &(*pPageList2)[ nMasterNum ];
2554                         }
2555                     }
2556                     if ( pMasterPersist )
2557                     {
> > >     CID 1321600:  Null pointer dereferences  (REVERSE_INULL)
> > >     Null-checking "pMasterPersist" suggests that it may be null, but it has already been 
> > > dereferenced on all paths leading to the check.
2558                         while( ( pMasterPersist && pMasterPersist->aSlideAtom.nFlags & 2 )  // 
it is possible that a masterpage
2559                             && pMasterPersist->aSlideAtom.nMasterId )                        
// itself is following a master colorscheme
2560                         {
2561                             auto nOrigMasterId = pMasterPersist->aSlideAtom.nMasterId;
2562                             sal_uInt16 nNextMaster = m_pMasterPages->FindPage(nOrigMasterId);
2563                             if ( nNextMaster == PPTSLIDEPERSIST_ENTRY_NOTFOUND )

** CID 1321599:  Control flow issues  (MISSING_BREAK)
/writerfilter/source/dmapper/DomainMapper.cxx: 2563 in 
writerfilter::dmapper::DomainMapper::sprmWithProps(writerfilter::Sprm &, 
std::shared_ptr<writerfilter::dmapper::PropertyMap>)()


________________________________________________________________________________________________________
*** CID 1321599:  Control flow issues  (MISSING_BREAK)
/writerfilter/source/dmapper/DomainMapper.cxx: 2563 in 
writerfilter::dmapper::DomainMapper::sprmWithProps(writerfilter::Sprm &, 
std::shared_ptr<writerfilter::dmapper::PropertyMap>)()
2557         break;
2558         case NS_ooxml::LN_EG_RunInnerContent_ruby:
2559         {
2560             RubyInfo    aInfo ;
2561             m_pImpl->SetRubyInfo(aInfo);
2562         }
> > >     CID 1321599:  Control flow issues  (MISSING_BREAK)
> > >     The above case falls through to this one.
2563         case NS_ooxml::LN_CT_RubyPr:
2564         case NS_ooxml::LN_CT_Ruby_rt:
2565         case NS_ooxml::LN_CT_Ruby_rubyBase:
2566         {
2567             m_pImpl->SetRubySprmId(nSprmId);
2568             if (nSprmId == NS_ooxml::LN_CT_RubyPr)

** CID 1321598:  Resource leaks  (CTOR_DTOR_LEAK)
/include/o3tl/cow_wrapper.hxx: 217 in o3tl::cow_wrapper<int, 
o3tltests::BogusRefCountPolicy>::cow_wrapper()()


________________________________________________________________________________________________________
*** CID 1321598:  Resource leaks  (CTOR_DTOR_LEAK)
/include/o3tl/cow_wrapper.hxx: 217 in o3tl::cow_wrapper<int, 
o3tltests::BogusRefCountPolicy>::cow_wrapper()()
211             typedef const T* const_pointer;
212             typedef MTPolicy mt_policy;
213     
214             /** Default-construct wrapped type instance
215              */
216             cow_wrapper() :
> > >     CID 1321598:  Resource leaks  (CTOR_DTOR_LEAK)
> > >     The constructor allocates field "m_pimpl" of "o3tl::cow_wrapper<int, 
> > > o3tltests::BogusRefCountPolicy>" but the destructor and whatever functions it calls do not free 
> > > it.
217                 m_pimpl( new impl_t() )
218             {
219             }
220     
221             /** Copy-construct wrapped type instance from given object
222              */

** CID 1321597:  Resource leaks  (CTOR_DTOR_LEAK)
/include/o3tl/cow_wrapper.hxx: 224 in o3tl::cow_wrapper<int, 
o3tltests::BogusRefCountPolicy>::cow_wrapper(const int &)()


________________________________________________________________________________________________________
*** CID 1321597:  Resource leaks  (CTOR_DTOR_LEAK)
/include/o3tl/cow_wrapper.hxx: 224 in o3tl::cow_wrapper<int, 
o3tltests::BogusRefCountPolicy>::cow_wrapper(const int &)()
218             {
219             }
220     
221             /** Copy-construct wrapped type instance from given object
222              */
223             explicit cow_wrapper( const value_type& r ) :
> > >     CID 1321597:  Resource leaks  (CTOR_DTOR_LEAK)
> > >     The constructor allocates field "m_pimpl" of "o3tl::cow_wrapper<int, 
> > > o3tltests::BogusRefCountPolicy>" but the destructor and whatever functions it calls do not free 
> > > it.
224                 m_pimpl( new impl_t(r) )
225             {
226             }
227     
228             /** Shallow-copy given cow_wrapper
229              */


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://scan.coverity.com/projects/libreoffice?tab=overview

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939