Re: [Libreoffice-commits] core.git: tdf#87702: Addition of Shadow sidebar tab

Caolán McNamara <caolanm -AT- redhat.com>

Tue, 11 Aug 2015 15:43:03 +0100

On Tue, 2015-08-04 at 18:15 +0200, Stephan Bergmann wrote:

--- a/cui/source/tabpages/tpshadow.cxx
+++ b/cui/source/tabpages/tpshadow.cxx
@@ -41,7 +41,10 @@ const sal_uInt16 
SvxShadowTabPage::pShadowRanges[] =
      SDRATTR_SHADOWCOLOR,
      SDRATTR_SHADOWTRANSPARENCE,
      SID_ATTR_FILL_SHADOW,
-    SID_ATTR_FILL_SHADOW,
+    SID_ATTR_SHADOW_COLOR,
+    SID_ATTR_SHADOW_TRANSPARENCE,
+    SID_ATTR_SHADOW_XDISTANCE,
+    SID_ATTR_SHADOW_YDISTANCE,


Doesn't this look odd, given pShadowRanges presumably shall consist 
of begin/end pairs?

Changed this to http://cgit.freedesktop.org/libreoffice/core/commit/?id =94fb1a389c3be0fd5570421baa596aeb79dc5528 which should fit better C.

Context

Re: [Libreoffice-commits] core.git: tdf#87702: Addition of Shadow sidebar tab · Stephan Bergmann

Re: [Libreoffice-commits] core.git: tdf#87702: Addition of Shadow sidebar tab · Caolán McNamara

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.