source

Eike Rathke <erack -AT- redhat.com>
Wed, 5 Aug 2015 12:53:56 +0200

Hi Noel,

On Monday, 2015-08-03 18:29:31 +0200, Noel Grandin wrote:

Oops, my mistake. Fixed in commit 5fcef02ee288c894a89c1046df918c121294b757


Thanks.

Which makes me think that automatically removing defines that something
thinks is unused, but that is unused only in a specific build
configuration, can be rather dangerous.

Any means to guard against this situation?

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack

Attachment: pgpMzjp3A0jKq.pgp
Description: PGP signature

Context

Re: [Libreoffice-commits] core.git: 2 commits - bin/find-unused-defines.sh dbaccess/source framework/inc i18nlangtag/source i18npool/inc include/toolkit include/vcl udkapi/com vcl/source · Eike Rathke
- Re: [Libreoffice-commits] core.git: 2 commits - bin/find-unused-defines.sh dbaccess/source framework/inc i18nlangtag/source i18npool/inc include/toolkit include/vcl udkapi/com vcl/source · Noel Grandin
  - Re: [Libreoffice-commits] core.git: 2 commits - bin/find-unused-defines.sh dbaccess/source framework/inc i18nlangtag/source i18npool/inc include/toolkit include/vcl udkapi/com vcl/source · Eike Rathke

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.