Re: [Libreoffice-commits] core.git: sw/qa

On 14.07.2015 08:21, Stephan Bergmann wrote:
> On 07/10/2015 01:09 PM, Varun wrote:
> > commit 6a0efa9873b1a5cae4ae0719a7ae1eee97838168
> > Author: Varun <varun.dhall@studentpartner.com>
> > Date:   Thu Jul 9 23:33:24 2015 +0530
> >
> >      Added Test for tdf#80663 table row/column delete undo crash
> >
> >      Change-Id: Ica62926486831f126cce54d651e230cee3360074
> >      Reviewed-on: https://gerrit.libreoffice.org/16901
> >      Reviewed-by: Michael Stahl <mstahl@redhat.com>
> >      Tested-by: Michael Stahl <mstahl@redhat.com>
>
> Looks like that new test unearthed an undo-related bug, as my asan+ubsan 
> build now reproducible fails during CppunitTest_sw_uiwriter with
>
> > sw/source/core/undo/untbl.cxx:997:25: runtime error: downcast of address 0x2b35a17ec0a8 which 
> > does not point to an object of type 'SwTableBoxFormat'
> > 0x2b35a17ec0a8: note: object is of type 'SwTableFormat'
> >  00 00 00 00  90 d9 e5 58 35 2b 00 00  a0 d2 7e a1 35 2b 00 00  f8 b1 7e a1 35 2b 00 00  00 60 
> > 6e 97
> >               ^~~~~~~~~~~~~~~~~~~~~~~
> >               vptr for 'SwTableFormat'

that looks like a bug but it happens to not crash since neither
SwTableFormat nor SwTableBoxFormat add members to their common base
class; fixed on master with commit e0cf60a4acfcb7788ebd145a1ddb7354b5d7d39a

good to hear that additional code coverage finds such bugs.