Hi Noel,
So - first thanks for the awesome plugin & initial patch =)
https://gerrit.libreoffice.org/#/c/16924/
I checked the basic/ NameContainer thing and ... wow =) it looks
totally busted; to some degree the question seems to be: how did that
ever work ? or is it even used ? ;-)
How many more do you find ? ;-) our brief IRC discussion (after you
dropped) went:
<mmeeks> noelgrandin, sberg: seems to me that stack, or member
allocating a WeakImplHelper is just a bug.
<sberg> to me too (w/o looking at any context, actually)
It would be great to have a list of other similar sillies - perhaps
there are some use-cases where it is ok. Eg. if we have some sort of
aggregate object - you could imagine that we could override 'acquire'
and get all the ref-counting on several different objects to count and
free the same object (I suppose). So in theory some of this could work
but ... ;-)
Does that help ?
ATB,
Michael.
--
michael.meeks@collabora.com <><, Pseudo Engineer, itinerant idiot
Context
- nice new plugin ... · Michael Meeks
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.