Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


On Mon, 2015-06-01 at 20:51 +0100, Caolán McNamara wrote:
On Sat, 2015-05-30 at 09:20 -0700, scan-admin@coverity.com wrote:
Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity 
Scan.

89 new defect(s) introduced to LibreOffice found with Coverity Scan.

One of these (1302618) is new from...

commit 02482eef0189e6c9f6ea233d495c9fd8a0d2a877
Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Date:   Thu May 28 18:42:39 2015 +0900

    fix drawing treelistbox with redefined background in dbaccess

    Change-Id: Ia55797e3e42309f9d37d5335088f7657d99954de

where in dbaccess/source/ui/app/AppDetailView.cxx:130 the _pEntry there
may be NULL given the above check for that,  and it always overwrites
the assign of line 125, should it be on an else branch of the 
if (_pEntry == GetCurEntry() condition
of line 108, or should line 125 be removed and line 130 brought
inside the if (_pEntry) on line 106 condition ?

I resolved this with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=88b104f44acff8087dfe3833bb91c63604ced98b
after examination shows that pEntry cannot be NULL

C.


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.