New Defects reported by Coverity Scan for LibreOffice

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

6 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by 
Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)


** CID 1298900:  Uninitialized members  (UNINIT_CTOR)
/sc/source/filter/excel/xeextlst.cxx: 282 in XclExpExtCfRule::XclExpExtCfRule(const XclExpRoot &, 
const ScFormatEntry &, const ScAddress &, const rtl::OString &, int)()


________________________________________________________________________________________________________
*** CID 1298900:  Uninitialized members  (UNINIT_CTOR)
/sc/source/filter/excel/xeextlst.cxx: 282 in XclExpExtCfRule::XclExpExtCfRule(const XclExpRoot &, 
const ScFormatEntry &, const ScAddress &, const rtl::OString &, int)()
276                 mxEntry.reset(new XclExpExtIconSet(*this, rIconSet, rPos));
277                 pType = "iconSet";
278             }
279             default:
280             break;
281         }
> > >     CID 1298900:  Uninitialized members  (UNINIT_CTOR)
> > >     Non-static class member "pType" is not initialized in this constructor nor in any functions 
> > > that it calls.
282     }
283     
284     void XclExpExtCfRule::SaveXml( XclExpXmlStream& rStrm )
285     {
286         if (!mxEntry)
287             return;

** CID 1298899:  Resource leaks  (RESOURCE_LEAK)
/sc/qa/unit/subsequent_filters-test.cxx: 2444 in <unnamed>::testCustomIconSetsXLSX_Impl(ScDocument 
&, short, int, ScIconSetType, int)()


________________________________________________________________________________________________________
*** CID 1298899:  Resource leaks  (RESOURCE_LEAK)
/sc/qa/unit/subsequent_filters-test.cxx: 2444 in <unnamed>::testCustomIconSetsXLSX_Impl(ScDocument 
&, short, int, ScIconSetType, int)()
2438         else
2439         {
2440             CPPUNIT_ASSERT(pInfo);
2441             CPPUNIT_ASSERT_EQUAL(nIndex, pInfo->nIconIndex);
2442             CPPUNIT_ASSERT_EQUAL(eType, pInfo->eIconSetType);
2443         }
> > >     CID 1298899:  Resource leaks  (RESOURCE_LEAK)
> > >     Variable "pInfo" going out of scope leaks the storage it points to.
2444     }
2445     
2446     }
2447     
2448     void ScFiltersTest::testComplexIconSetsXLSX()
2449     {

** CID 1298898:  Null pointer dereferences  (FORWARD_NULL)
/basctl/source/basicide/basobj3.cxx: 172 in basctl::RenameDialog(vcl::Window *, const 
basctl::ScriptDocument &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)()


________________________________________________________________________________________________________
*** CID 1298898:  Null pointer dereferences  (FORWARD_NULL)
/basctl/source/basicide/basobj3.cxx: 172 in basctl::RenameDialog(vcl::Window *, const 
basctl::ScriptDocument &, const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)()
166             ScopedVclPtrInstance< MessageDialog > aError(pErrorParent, 
IDE_RESSTR(RID_STR_BADSBXNAME));
167             aError->Execute();
168             return false;
169         }
170     
171         Shell* pShell = GetShell();
> > >     CID 1298898:  Null pointer dereferences  (FORWARD_NULL)
> > >     Comparing "pShell" to null implies that "pShell" might be null.
172         DialogWindow* pWin = pShell ? pShell->FindDlgWin(rDocument, rLibName, rOldName) : 0;
173         Reference< XNameContainer > xExistingDialog;
174         if ( pWin )
175             xExistingDialog = pWin->GetEditor().GetDialog();
176     
177         if ( xExistingDialog.is() )

** CID 1298897:  Control flow issues  (DEADCODE)
/oox/source/export/chartexport.cxx: 131 in 
oox::drawingml::<unnamed>::translateFromChart2AxisIndexToOox(int)()


________________________________________________________________________________________________________
*** CID 1298897:  Control flow issues  (DEADCODE)
/oox/source/export/chartexport.cxx: 131 in 
oox::drawingml::<unnamed>::translateFromChart2AxisIndexToOox(int)()
125         if (nIndex == 0)
126             return AXIS_PRIMARY_Y;
127         else if (nIndex == 1)
128             return AXIS_SECONDARY_Y;
129     
130         // good default value for release builds
> > >     CID 1298897:  Control flow issues  (DEADCODE)
> > >     Execution cannot reach this statement: "return 2;".
131         return AXIS_PRIMARY_Y;
132     }
133     
134     }
135     
136     class lcl_MatchesRole : public ::std::unary_function< Reference< 
chart2::data::XLabeledDataSequence >, bool >

** CID 1298896:  Control flow issues  (DEADCODE)
/oox/source/export/drawingml.cxx: 1806 in 
oox::drawingml::DrawingML::getBulletMarginIndentation(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>,
 short, const rtl::OUString &)()


________________________________________________________________________________________________________
*** CID 1298896:  Control flow issues  (DEADCODE)
/oox/source/export/drawingml.cxx: 1806 in 
oox::drawingml::DrawingML::getBulletMarginIndentation(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>,
 short, const rtl::OUString &)()
1800             }
1801         }
1802     
1803         if (nNumberingType == SVX_NUM_NUMBER_NONE)
1804             return 0;
1805     
> > >     CID 1298896:  Control flow issues  (DEADCODE)
> > >     Execution cannot reach this statement: "return 0;".
1806         return 0;
1807     }
1808     
1809     const char* DrawingML::GetAlignment( sal_Int32 nAlignment )
1810     {
1811         const char* sAlignment = NULL;

** CID 1298895:  Control flow issues  (DEADCODE)
/sc/source/ui/miscdlgs/autofmt.cxx: 334 in ScAutoFmtPreview::DrawString(OutputDevice &, unsigned 
long, unsigned long)()


________________________________________________________________________________________________________
*** CID 1298895:  Control flow issues  (DEADCODE)
/sc/source/ui/miscdlgs/autofmt.cxx: 334 in ScAutoFmtPreview::DrawString(OutputDevice &, unsigned 
long, unsigned long)()
328                     case SVX_HOR_JUSTIFY_BLOCK:
329                     case SVX_HOR_JUSTIFY_REPEAT:
330                     case SVX_HOR_JUSTIFY_CENTER:
331                         aPos.X() += nHorPos;
332                         break;
333                     // coverity[dead_error_begin] - following conditions exist to avoid 
compiler warning
> > >     CID 1298895:  Control flow issues  (DEADCODE)
> > >     Execution cannot reach this statement: "case SVX_HOR_JUSTIFY_STANDARD:".
334                     case SVX_HOR_JUSTIFY_STANDARD:
335                     default:
336                         // Standard is not handled here
337                         break;
338                 }
339             }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/211?tab=overview

To manage Coverity Scan email notifications for "libreoffice@lists.freedesktop.org", click 
https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939
 .