Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index 

Hi Noel,

        I just finished cleaning up all the VclBuilder 'makeFoo' constructors -
and will push to master in a sec.

        I was wondering - would it be possible to have a clang plugin that
checks for all instances of new <type> where type is derived from
OutputDevice ? =)

        Those new calls should really all be either:

        a) VclPtr< type >::Create
or
        b) VclPtr< type >( new <type>, SAL_NO_ACQUIRE )

        I hope the impl. of a) is covered by b) =)

        It'd be great to know that no-one is leaking Windows as they are
created, and of course that no-one is mis-using SAL_NO_ACQUIRE
inadvertently either =)

        Any chance ? =)

        Thanks,

                Michael.

-- 
 michael.meeks@collabora.com  <><, Pseudo Engineer, itinerant idiot

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.