[Bug 90793] New: Fix the HiDPI wave underline character property

https://bugs.documentfoundation.org/show_bug.cgi?id=90793

            Bug ID: 90793
           Summary: Fix the HiDPI wave underline character property
           Product: LibreOffice
           Version: 4.2.3.3 release
          Hardware: Other
                OS: Linux (All)
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: UI
          Assignee: libreoffice-bugs@lists.freedesktop.org
          Reporter: keithcu@gmail.com
                CC: libreoffice@lists.freedesktop.org

LibreOffice since 4.2.3 draws the spelling and grammar error waves lines nicely
on HiDPI screens. This was done via changes to the OutputDevice::DrawWaveLine
routine:
http://opengrok.libreoffice.org/xref/core/vcl/source/outdev/textline.cxx#984

This fixes by far the most common use of this feature, but still we could do a
better job for the underline character properties (wave, bold-wave,
double-wave) which are hard-coded to draw 1 pixel and don't look very good. The
relevant routine for this is OutputDevice::ImplDrawWaveLine

http://opengrok.libreoffice.org/xref/core/vcl/source/outdev/textline.cxx#88

I believe this is an easy hack. The first question is what widths to use. The
spelling / grammar underlines are supposed to be unobtrusive, but the wave
underline character property perhaps not. I would consider changing the code to
use the underline / bold / double underline widths, or perhaps tweaks of them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.