Re: New Defects reported by Coverity Scan for LibreOffice

Hi Caolán,

On Thursday, 2015-04-16 09:29:51 +0100, Caolán McNamara wrote:

> > /sc/source/core/tool/compiler.cxx: 5037 in ScCompiler::HandleTableRef()()
> > > > >     CID 1294407:  Incorrect expression  (COPY_PASTE_ERROR)
> > > > >     "aStart" in "aColRange.aEnd.Row() != aDBRange.aStart.Row()" looks like a copy-paste 
> > > > > error.
> > 5037                     if (aColRange.aStart.Row() != aDBRange.aStart.Row() || 
> > aColRange.aEnd.Row() != aDBRange.aStart.Row())
> > 5038                         aRange = ScRange( ScAddress::INITIALIZE_INVALID);
>
> caolanm->erack: should it be
>
> ... || aColRange.aEnd.Row() != aDBRange.aEnd.Row()

No, this is a false positive, both aColRange rows must be equal to the
aDBRange start row, the headers row.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack

Attachment: pgpuzgclDpTJt.pgp
Description: PGP signature