Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index 

Hi,

Before 9ae701509add0f0192b02fab787c6acbc64be349 FastAttributeList used
map to store attribute="value" pairs in XML elements. I guess I did
not realize when changing map to list that it will cause problems
because somebody writes the same attribute twice.

One problem is described in
https://bugs.documentfoundation.org/show_bug.cgi?id=85769 for which I
did https://gerrit.libreoffice.org/#/c/15367/
but no idea if that fix is OK.
Caolan tried to avoid assert with 969c1d5e44ed11e08f64334ed65ce01d2fa54acb
(but I now get "Assertion `aColorString.equalsL(pExistingValue,
rtl_str_getLength(pExistingValue))' failed." for docx/fdo72640-3.docx)

The question is: should we return to using map in Writer or try to fix
these problems one by one as they come?

Feel free to approve https://gerrit.libreoffice.org/#/c/15367/ :-)

Thanks,

Matus

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.