Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


https://bugs.documentfoundation.org/show_bug.cgi?id=90290

David Tardon <dtardon@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtardon@redhat.com

--- Comment #13 from David Tardon <dtardon@redhat.com> ---
(In reply to Markus Mohrhard from comment #0)
ucalc is one of the mail calc tests and is split between many files in
sc/qa/unit

This task is about improving the existing pattern around checkFormula in
sc/qa/unit/ucalc_formula.cxx

A typical piece of code looks like this:

    if (!checkFormula(*m_pDoc, aPos, "SUM(A3:A7)"))
        CPPUNIT_FAIL("Wrong formula!");

This should be changed to something like:

checkFormula(*m_pDoc, aPos, "SUM(A3:A7)", "Wrong formula!");

What is wrong with

CPPUNIT_ASSERT_MESSAGE("Wrong formula!", checkFormula(*m_pDoc, aPos,
"SUM(A3:A7)"))

? That would address Kohei's concerns without any necessary changes to cppunit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.