https://bugs.documentfoundation.org/show_bug.cgi?id=90290
--- Comment #7 from Kohei Yoshida <libreoffice@kohei.us> ---
BTW, just to mention this for the record, I did this type
if (!checkFormula(*m_pDoc, aPos, "SUM(A3:A7)"))
CPPUNIT_FAIL("Wrong formula!");
of checks so that when it fails, you can get the line number of where the check
actually fails. One disadvantage of writing a common function for this is that
when the check fails, the line number now points where inside that shared
function, not where it was called, and then you'd have to do some hunting to
see which check actually failed in what test case.
I'm not saying "don't do it", but I'm simply saying there is a thought behind
it, and there is a disadvantage to "cleaning it up".
--
You are receiving this mail because:
You are on the CC list for the bug.
Context
- [Bug 90290] reduce some copy&paste code in ucalc · bugzilla-daemon
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.