Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


On 03/23/2015 09:54 AM, Miklos Vajna wrote:
I'm not sure why loplugin:cstylecast did not catch these earlier

Because it only warns about a select subset of C-style casts, not including "CK_NoOp - A conversion which does not affect the type other than (possibly) adding qualifiers." Working to improve that.

/home/vmiklos/git/libreoffice/master-clang/sw/source/core/doc/docfmt.cxx:657:26: error: c-style 
cast, type=5, from='const sw::WriterListener *', to='SwClient *', recommendedFix=static_cast 
[loplugin:cstylecast]
     while( 0 != ( pDep = (SwClient*)aCallMod.GetDepends()) )
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Already reverted that commit with <http://cgit.freedesktop.org/libreoffice/core/commit/?id=5fb7f222f51b93a9dfffa0fe211a5b3e0c83757e> before seeing this mail thread.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.