On 2015-03-18 03:01 PM, Piet van Oostrum wrote:
About a week ago I submitted a patch to gerrit (https://gerrit.libreoffice.org/#/c/14841/).
However, the build failed on Windows, due to a unit test failing. I looked in the log file and it
seems to me that the unit test failure is not related to my patch. So what should I do next?
Shall I resubmit the patch, possibly after rebasing it to the current master? This is the first
time I am doing this, so I have no experience. I also don't know if the patch will be reviewed,
given that the build failed. Or will it be considered anyway?
Unit test failures are not really a problem, unless it is obvious that you introduced them.
However, I note that Miklos asked you to add a unit test. Doing that would probably ensure that
your change is committed :-)
Context
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.