Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


Removed the Prefix :)

2dc1136e2287b52ba3c3c58a1d70de78ad53fef7

Cheers

Tobi

On Thu, Jan 22, 2015 at 12:14 PM, Miklos Vajna <vmiklos@collabora.co.uk>
wrote:

On Thu, Jan 22, 2015 at 10:58:13AM +0100, Tobias Madl <
tobias.madl.dev@gmail.com> wrote:
But i don't get the thing with changing it to a C++11 enum class. It is
already an enum class ????

In your feature branch, you have:

 enum class IdlePriority {

That's a C++11 enum class.

On master, it's:

enum IdlePriority {

That's why I said -- if you change it to an enum class and you need to
adjust all client code anyway, then I would also drop the now redundant
prefixes as well. See 22f0862ae782c90306d444d2f5aa253b9e97acd2 for
example or 5333782d090a9e147c0c431f0f741863d1d8cf8e.

Regards,

Miklos


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.