Date: prev next · Thread: first prev next last
2015 Archives by date, by thread · List index


Hi all,

I'm looking for someone, who can tell me more about method View::GetEmptyPresentationObject()[1]. The method is used in FuInsertGraphic::DoExecute() with parameter PRESOBJ_GRAPHIC [2] and in View::InsertMediaObj() with parameter PRESOBJ_MEDIA [3] and in DrawViewShell::FuTable with parameter PRESOBJ_TABLE [4]. But the delivered parameter is not considered in all cases in GetEmptyPresentationObject().

This method has been introduced with commit "renaissance01: #i107213# further layout work, initial support for new layout toolbox control" by Christian Lippka at 3.Dec 2009.

I come across the method when investigating on AOO bug #125613 [5]. The call with parameter PRESOBJ_GRAPHIC results in an object of kind PRESOBJ_OUTLINE. I think, it should be NULL.

I know, it is an AOO problem, but it might be reason for fdo#64301 [6] too.

My question is: Is the implemented behavior of GetEmptyPresentationObject() intended, and if yes, why? Or is it a bug?

Kind regards
Regina

[1] http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/sdview5.cxx
[2] http://opengrok.libreoffice.org/xref/core/sd/source/ui/func/fuinsert.cxx
[3] http://opengrok.libreoffice.org/xref/core/sd/source/ui/view/sdview4.cxx
[4] http://opengrok.libreoffice.org/xref/core/sd/source/ui/table/tablefunction.cxx
[5] https://issues.apache.org/ooo/show_bug.cgi?id=125613
[6] https://bugs.freedesktop.org/show_bug.cgi?id=64301



Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.