remove_if for nothing in dbdata.cxx (sc module)

julien2412 <serval2412 -AT- yahoo.fr>

Sun, 28 Dec 2014 09:08:57 -0700 (MST)

Hello, I noticed this part: 889 void ScDBCollection::DeleteOnTab( SCTAB nTab ) 890 { ... 908 remove_if(maAnonDBs.begin(), maAnonDBs.end(), func); 909 } "remove_if" is useless since there's no erase. I thought about adding an "erase" by taking example of this http://en.wikipedia.org/wiki/Erase-remove_idiom but AnonDBs doesn't have an ad hoc erase method (like NamedDBs, but this one has a "simple" erase method), see http://opengrok.libreoffice.org/xref/core/sc/inc/dbdata.hxx#152 Should we remove this line? Should we add an ad hoc "erase" method to implement erase-remove idiom in NamedDBs + AnonDBs? Any thoughts? Julien -- View this message in context: http://nabble.documentfoundation.org/remove-if-for-nothing-in-dbdata-cxx-sc-module-tp4134249.html Sent from the Dev mailing list archive at Nabble.com.

Context

remove_if for nothing in dbdata.cxx (sc module) · julien2412

Re: remove_if for nothing in dbdata.cxx (sc module) · Will Entriken

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.