Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index


https://bugs.freedesktop.org/show_bug.cgi?id=84938

--- Comment #6 from Noel Grandin <noelgrandin@gmail.com> ---
Glad to here you are working on this!

(In reply to Terrence Enger from comment #5)
(*) I have the name DatasourceItemId for the class.  Is this good?

Sounds finee.

(*) The member name looks like a #defined name: uppercase with
    underscores between "words".  Does anybody care for more details?

Sounds fine.

(*) I have changed to types of data members in some other classes.  I
    do not see why these variables are necessary, but I have not dug
    into the question.

That's pretty normal.

(*) So far, I have arbitrarily limited my changes to dbaccess; when
    an item goes outside the module--SfxItemSet comes to mind--I have
    cast the item to int.  Is this a reasonable way to do it?  Failing
    that, is the result worth anything?

That's a normal approach, except for cases where something else might be
#including headers from dbaccess, in which case I'd except the code to
be modified to use the new 'enum class' type.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.