Hi David, On Sat, Oct 11, 2014 at 11:57:13PM +0200, David Ostrovsky <d.ostrovsky@idaia.de> wrote:
on very recent master (9aad656156fbf76288e8a281760e60f1eccc6622),
on VS 2013 the xmlexport tests are failing here [1]:
// This is 17667 in the original document, was 504666 (so the image
// become invisible), now is around 19072.
CPPUNIT_ASSERT(getXPath(pXmlDoc, "//a:srcRect",
"l").toInt32() < 20000);
looking into it, reveals that the XPATH in question is:
<a:srcRect l="23842" t="0" r="23842" b="0" />
the whole word/document.xml is [2] and the stack trace is [3].
It looks like this test was added recently, in this commit: 4cdce63d.
On VS2013 i was able to build LO with all tests before. When i increase
the value to 24000 to pass this specific tests
That's quite interesting, you mean that in this case VS 2012 and VS 2013 generates different code? It would be good to find out what causes the difference. Of course, as the comment says it was around 500 000 before, so you can work around the problem with raising the limit to e.g. 24000, but it would be nice to find out the root cause. ;-)
, then the next test that is failing is: testExportImageProperties::Import_Export [4], that sounds familiar: 'hspace' of '/html/body/p/a/font/img' incorrect value
See the comment in that test, it's already disabled on OSX, so option #1 is to do what the comment already says, option #2 is to just disable it for VS 2013 as well. Regards, Miklos
Attachment:
signature.asc
Description: Digital signature