Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index


On Tuesday 23 of September 2014, Andras Timar wrote:
On Tue, Sep 23, 2014 at 10:10 PM, Jean-Baptiste Faure

<jbfaure@libreoffice.org> wrote:
Hi,

The build of 4.3 branch fails on the following unit test :

[build CUT] sw_ooxmlimport
File tested,Execution Time (ms)
bnc891663.docx,[...]/LibO/lo43/sw/qa/extras/ooxmlimport/ooxmlimport.cxx:2
284:testBnc891663::Import assertion failed
- Expression: textNextRowTop >= imageTop + imageHeight

Unfortunately the fix worked only for master. I accepted the patch for
libreoffice-4-3, but it was a mistake. I reverted it.

 My bad, the original code had several unhandled switch cases together and I 
overlooked that (not that I get how the fix worked in master).

 Andras, could you please include the commit back to 4.2+4.3 together with 
74c6ba1b741ae76ad9e2f2b81be3e3178163f085 ? Thanks.

-- 
 Lubos Lunak
 l.lunak@collabora.com

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.