Re: Chained Text Boxes - Cleaning up code before incorporation to master - Are we okay with changes to #i119885#?

What I did:
- make check
- make slowcheck
- make subsequentcheck
So far, so good.
Do such commands already run tests?

Then I tried to see what the description of the code I removed was and to
play with Draw in case I saw anything suspicious (the change is in svx, are
Impress and Draw the only possible damaged spots?).
From a comment:
"#i119885# Do not limit/force height to geometrical frame (vice versa for
vertical writing)"
Link to the issue in the bugtracking:
https://issues.apache.org/ooo/show_bug.cgi?id=119885

And there is something not quite working: when "Fit to height" is off for a
box then you cannot see any overflowing text while editing.
Next step is seeing if this is caused by some other parts of my code or by
that specific change.

Matteo


On Mon, Sep 22, 2014 at 1:30 AM, Thorsten Behrens <
thb@documentfoundation.org> wrote:

> mmh - so nope, I'm afraid that will likely break things in master, so
> I'd prefer if we fix that in the branch. First thing to do is to run
> all tests (including make slowcheck and make subsequentcheck). If you
> played with all applications, and are reasonably certain no observable
> behaviour changed, of course we can merge that (after giving some
> advance warning here on the dev and QA list).
>
> And thanks for digging into this again!
>
> Cheers,
>
> -- Thorsten