Re: [RFC} running a formatter over the Java code

On 05/08/14 09:26, Noel Grandin wrote:
> Hi
>
> <Dons flame-proof suit>
>
> Would there be any objections to my running a formatter over the
> existing Java LO code (with the exception of the newer Android stuff) ?
>
> Because at the moment
> - it has very little consistency
> - and it appears that at some point in time a tabs-to-spaces conversion
> was done, but not all the files followed the same tab-size convention,
> so some of the formatting is now REALLY out.

If you're going to do that, can you investigate a git hook or whatever
it is that will enforce that convention on commit?

That would then be a good prototype for the rest of the code base :-)
> I am suggesting using the standard Oracle Java code formatting conventions
>   http://www.oracle.com/technetwork/java/codeconventions-150003.pdf
> which largely match the bulk of the existing style.
Sounds sensible to me ... especially if you also investigate formatting
hooks on checkout :-)

Cheers,
Wol