Re: [libreoffice] allow passing FilterOptions via cli

Hi Stephan,

thank you very much for pushing the patch.

I updated https://wiki.documentfoundation.org/Development/Developers to
cover this identity too.

From your remark
<https://bugs.freedesktop.org/show_bug.cgi?id=36313#c17> I understand,
that it does not seem very user friendly.  However, the patch at least
makes it possible to achieve the desired behaviour, which was not
possible previously.  Maybe the remaining problem should be seen as how
to make the CVS filter options more user friendly?  I don't have an
answer to that, unfortunatelly.

I found another bug report
<https://bugs.freedesktop.org/show_bug.cgi?id=47892> which explicitly
asks for FilterOptions at least for --convert-to so I should have
probably addressed this, but I found it later.

Should I mark <https://bugs.freedesktop.org/show_bug.cgi?id=47892> as
resolved or leave it to QA people to handle that?

Thank you,

Tomas

On 06/04/2014 01:04 PM, Stephan Bergmann wrote:
> On 06/03/2014 02:01 PM, Tomas Hlavaty wrote:
> > I wrote a patch to allow passing FilterOptions via cli,
> > which fixes <https://bugs.freedesktop.org/show_bug.cgi?id=36313>.
> > The patch is attached.
> >
> > The patch takes the FilterOptions from --infilter and --convert-to args
> > using : as a delimiter.  This should hopefully not be a problem,
> > it is current separator used in --convert-to and I am not aware of a
> > filter
> > name containing that character.  If that is a problem, the separator
> > could
> > be easily changed to a different character.
> >
> > The patch was written on top of libreoffice-4-3-branch-point tag
> > (which compiled for me without serious problems).
> > Would it be possible to cherry-pick the bug fix also to a fresh 4.2.X
> > release?
>
> Thanks for your patch, I have pushed it to master (towards LO 4.4)
> now,
> <http://cgit.freedesktop.org/libreoffice/core/commit/?id=45ba4d79d968f81f74ef0c4588fd15b1ce91153f>
> "fdo#36313: allow passing FilterOptions via cli."  (Assuming the
> "Tomas Hlavaty <tomas.hlavaty@knowledgetools.de>" identity is covered
> by
> <http://lists.freedesktop.org/archives/libreoffice/2012-January/023333.html>
> "[Libreoffice] License statement" on file at
> <https://wiki.documentfoundation.org/Development/Developers>.)
>
> However, see my remark at
> <https://bugs.freedesktop.org/show_bug.cgi?id=36313#c17>:  "I am not
> sure whether the fix [...] is already a practical-enough solution?"
>
> Stephan