Re: avoiding cppunit zerodiv correction

julien2412 <serval2412 -AT- yahoo.fr>

Fri, 30 May 2014 13:41:33 -0700 (PDT)

Matteo Casalin-3 wrote

...
I don't have any comment about your proposal, but just would like to
add that unless we know for sure that nHeight!=0 at that point, in
both codes the check should be

if( nHeight <= 0 )

in order to solve the division by 0 completely.

You're right of course. Sorrry for this change which was indeed wrong, I reverted it (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea15c9dc4da75fcd56e6b0dbce473b9e912fa4e2) Julien -- View this message in context: http://nabble.documentfoundation.org/avoiding-cppunit-zerodiv-correction-tp4110788p4110872.html Sent from the Dev mailing list archive at Nabble.com.

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.