Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index


https://bugs.freedesktop.org/show_bug.cgi?id=79123

--- Comment #3 from Björn Michaelsen <bjoern.michaelsen@canonical.com> ---
(In reply to comment #1)
exception: if a patch has been marked with negative feedback by the author
of the patch himself, leave it alone
marking one's patch with -2 is used to indicate a 'working' patch..

No even then. The recommended way to do a working patch is using drafts:

 https://wiki.documentfoundation.org/Gerrit#Submitting_patches_as_drafts

Everything else is frustrating reviewers checking "open" changes.

Also, even _if_ a change would still be uploaded accidentally for review
although it is not intended to be merged as is, there is little harm done, when
the change is abandoned under the conditions above. Reviving a abandoned change
is trivial and the autoabandon is actually a helpful reminder -- better than
letting them stay in limbo for months.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.