Hey,
so by going through Lsan reports I noted that we have a few classes in
formula that are marked with SAL_NO_VTABLE and therefore have no virtual
protected destructors, This prevents us from deleting some of these
instances and it looks like people just leaked them in the past.
Is there any reason not to remove the SAL_NO_VTABLE and make the destructor
virtual and public. I"m talking especially about
include/formula/IFunctionDescription.hxx where the use of SAL_NO_VTABLE
looks like premature optimization to me.
Regards,
Markus
Context
- SAL_NO_VTABLE in formula · Markus Mohrhard
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.