Re: Wrong copy paste in ucbcmds.cxx? (ucb module)

On 05/17/2014 01:26 AM, julien2412 wrote:
> I noticed this part:
>      236 CommandProcessorInfo::CommandProcessorInfo()
>      237 {
>      238     m_pInfo = new uno::Sequence< ucb::CommandInfo >( 2 );
>      239
>      240     (*m_pInfo)[ 0 ]
>      241         = ucb::CommandInfo(
>      242             OUString( GETCOMMANDINFO_NAME ), // Name
>      243             GETCOMMANDINFO_HANDLE, // Handle
>      244             getCppuVoidType() ); // ArgType
>      245     (*m_pInfo)[ 1 ]
>      246         = ucb::CommandInfo(
>      247             OUString( GLOBALTRANSFER_NAME ), // Name
>      248             GLOBALTRANSFER_HANDLE, // Handle
>      249             cppu::UnoType<ucb::GlobalTransferCommandArgument>::get()
> ); // ArgType
>      250     (*m_pInfo)[ 2 ]
>      251         = ucb::CommandInfo(
>      252             OUString( CHECKIN_NAME ), // Name
>      253             CHECKIN_HANDLE, // Handle
>      254             cppu::UnoType<ucb::GlobalTransferCommandArgument>::get()
> ); // ArgType
>      255 }
> See
> http://opengrok.libreoffice.org/xref/core/ucb/source/core/ucbcmds.cxx#257
>
> I wonder if line 254 could be a wrong copy paste and should be:
> cppu::UnoType<ucb::CheckinArgument>::get() );

Yes, that's wrong.  (See UniversalContentBroker::execute in 
ucb/source/core/ucb.cxx, where CHECKIN_HANDLE/CHECKIN_NAME expects to 
get a CheckinArgument, not a GlobalTransferCommandArgument.

Stephan