Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index


Hello,

Taking a look to this part:
   4442                 if ( nErrCode == ERRCODE_NONE )
   4443                 {
   4444                     p_EscherBlibEntry->meBlibType = ( eGraphicType
== GRAPHIC_BITMAP ) ? PNG : EMF;
   4445                     aStream.Seek( STREAM_SEEK_TO_END );
   4446                     p_EscherBlibEntry->mnSize = aStream.Tell();
   4447                     pGraphicAry = (sal_uInt8*)aStream.GetData();
   4448 
   4449                     if ( p_EscherBlibEntry->meBlibType == WMF )    
// the fileheader is not used
   4450                     {
   4451                         p_EscherBlibEntry->mnSize -= 22;
   4452                         pGraphicAry += 22;
   4453                     }
   4454                 }

I wonder if in line 4449 'WMF' should be changed to 'EMF' or the contrary on
line 4444.
See
http://opengrok.libreoffice.org/xref/core/filter/source/msfilter/escherex.cxx#4444
A research in Opengrok didn't help:
http://opengrok.libreoffice.org/search?q=%22eGraphicType+%3D%3D+GRAPHIC_BITMAP%22&project=core&defs=&refs=&path=&hist=

Any idea?

Julien 



--
View this message in context: 
http://nabble.documentfoundation.org/Dead-code-in-escherex-cxx-filter-module-tp4106079.html
Sent from the Dev mailing list archive at Nabble.com.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.