Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index 

On 04/03/2014 02:16 PM, Michaël Lefèvre wrote:

While submitting https://gerrit.libreoffice.org/8630  Stephen Bergmann
accepted to keep OSL_TRACE because I'm patching C file.
Is there any rules as of using SAL_... for C++ code, and OSL_... for C
code ?
There's generally no good reason to have C code in our code base at all, so the best approach IMO is to first convert a "problematic" C file to CXX and then modify it. (Incidentally, I happened to do exactly that to sal/osl/unx/security.c post <https://gerrit.libreoffice.org/8630> "fdo#56284 : soffice fails to start unless ~/.config exists and is writable" with <http://cgit.freedesktop.org/libreoffice/core/commit/?id=d37e9645edbdabaaf16ce0f1f904405f3477dc41> "sal/osl/unx/security.c -> .cxx" and <http://cgit.freedesktop.org/libreoffice/core/commit/?id=6cd87e5ee27af05cf54ba56d06f519a8f7138e8a> "coverity#1194930 Avoid TOCTOU between access and mkdir.") 

Stephan


Please put me in CC, not subscribed to the list.

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.