Hello,
Cppcheck reported this:
sc/source/core/opencl/op_statistical.cxx
3221 duplicateExpression style Same expression on both sides of '&&'.
3233 duplicateExpression style Same expression on both sides of '&&'.
3245 duplicateExpression style Same expression on both sides of '&&'.
3305 duplicateExpression style Same expression on both sides of '&&'.
3317 duplicateExpression style Same expression on both sides of '&&'.
eg:
3220 else if ((pDVR->IsStartFixed() && !pDVR->IsEndFixed())
3221 &&(pDVR->IsStartFixed() && !pDVR->IsEndFixed()))
(see
http://opengrok.libreoffice.org/xref/core/sc/source/core/opencl/op_statistical.cxx#3220)
Should the second line use pDVR1 (like some other parts), should the second
line be removed each time, or something else should be done?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Cppcheck-reports-Same-expression-on-both-sides-of-sc-module-tp4103436.html
Sent from the Dev mailing list archive at Nabble.com.
Context
- Cppcheck reports Same expression on both sides of '&&' (sc module) · julien2412
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.