Date: prev next · Thread: first prev next last
2014 Archives by date, by thread · List index


https://bugs.freedesktop.org/show_bug.cgi?id=75757

--- Comment #6 from Jan Holesovsky <kendy@collabora.com> ---
As I have just talked to other guy that was a bit confused here; let me
describe the task more thoroughly :-)

First - what is bad about inheriting from the container.  It is that that way,
you are exposing much more functionality that would be necessary in this case;
like all the container functionality that might be misused to overcome the API
that is intended here.

So for the PropertyMap, as an example:

You want to remove the inheriting from _PropertyMap, and instead provide a

_PropertyMap m_aPropMap;

private member variable.

Then change all the find(), begin(), end() etc. to m_aPropMap->find(),
m_aPropMap->begin(), m_aPropMap->end() so that the container methods are not
exposed in any way, and the GetPropertyValues() and Insert() methods are the
only way how to access the internal structure(s).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.