Re: [PATCH] FILESAVE: Empty custom properties are lost while saving in .doc format

On 26/02/14 08:07, Tarun Kumar wrote:
> Hi,
>
> The Bug is filed and accepted at: https://bugs.freedesktop.org/show_bug.cgi?id=75243
>
> Steps to reproduce:
> 1. Open Writer and use a document .doc
> 2. Add it a custom property. Don't enter any value for the property
> 3. Save it and close Writer
> 4. Open again Writer and use same document recently saved.
> 5. Custom property is lost.

hi Tarun,

agreed, custom properties should be saved even if empty.

> Attached is a patch that solves the problem. Patch is also attached to the bug.
> Please consider this patch for inclusion.

great, your patch fixes the problem!

looking at sfx2/source/doc/docinf.cxx there are numerous calls (affected
by your patch) to the function SetStringValue with static ID, and i'm
not sure whether it is better or worse to store e.g. an Author property
that is empty; have you thought about this?

also, could you please create the patch with "git commit" and put the
bug ID "fdo#75243" in the first line of the commit message, and then
"git format-patch HEAD~".

> I declare that this and my further patches are under LGPLv3+ / MPL license.

great, feel free to add yourself to
 https://wiki.documentfoundation.org/Development/Developers

regrads,
 michael