Re: [PATCH] fdo#61320: Allow user to choose whether to create thumbnails

Hi Christian,

On Mon, 2014-02-10 at 11:53 +0100, Michael Stahl wrote:
> On 10/02/14 08:42, Christian Junker wrote:
> > Hello developers,
> >
> > this is my first LO patch for review. It enhances LibreOffice by making
> > the thumbnail creation inside odf archive files optional. In some cases
> > users might not want to have a thumbnail included inside their document,
> > because they need the file to be as small as possible.
> >
> > I have added a new save option to the Options dialog under section
> > Load/Save > General, whose name might still get improved possibly, so
> > far it is not translated into other languages:
> > "Include a thumbnail image".
>
> hi Christian,
>
> thanks for your patch, the configuration setting is mostly fine ...

Right, so I've pushed your patch as
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0035b3218d8652652e62afe89eddfd28a9021b75
without the UI changes as discussed in the bug
https://bugs.freedesktop.org/show_bug.cgi?id=61320
Thanks for you contribution, indeed for small files it saves a lot.
Hopefully, it's easy enough to change the setting in expert config
dialog and you can change it just once.

I've also added you to
https://wiki.documentfoundation.org/Development/Developers#J

Looking forward to next contributions,
Thanks,

Matus