https://bugs.freedesktop.org/show_bug.cgi?id=75280
Priority: medium
Bug ID: 75280
CC: libreoffice@lists.freedesktop.org,
vicenzi.alexandre@gmail.com
Assignee: libreoffice-bugs@lists.freedesktop.org
Summary: [Easyhack] Convert inappropriate use of sal_uIntPtr to
better integer types
Severity: normal
Classification: Unclassified
OS: All
Reporter: mstahl@redhat.com
Hardware: Other
Status: NEW
Version: Inherited From OOo
Component: Libreoffice
Product: LibreOffice
During the removal of the tools types, the ULONG type was initially
converted to sal_uIntPtr, before those doing that work switched to
using the stop-gap sal_uLong type instead.
sal_uIntPtr has a very special purpose, variables of this type
hold pointers that are converted to integers.
any use of the sal_uIntPtr type that is actually "just" an integer
should be replaced by an appropriate unsigned integer type,
depending on the situation sal_uInt32, sal_uInt64, size_t or
"unsigned int" are likely candidates.
as an example, take the UniqueIndexImpl class.
it stores sal_uInt32 internally but its public interfaces are
defined on sal_uIntPtr; it is obvious that sal_uIntPtr should
be replaced by sal_uInt32 here in UniqueIndexImpl and its clients.
--
You are receiving this mail because:
You are on the CC list for the bug.
Context
- [Bug 75280] New: [Easyhack] Convert inappropriate use of sal_uIntPtr to better integer types · bugzilla-daemon
Privacy Policy |
Impressum (Legal Info) |
Copyright information: Unless otherwise specified, all text and images
on this website are licensed under the
Creative Commons Attribution-Share Alike 3.0 License.
This does not include the source code of LibreOffice, which is
licensed under the Mozilla Public License (
MPLv2).
"LibreOffice" and "The Document Foundation" are
registered trademarks of their corresponding registered owners or are
in actual use as trademarks in one or more countries. Their respective
logos and icons are also subject to international copyright laws. Use
thereof is explained in our
trademark policy.