[Bug 63154] replace tools/solar.h macros with osl versions

https://bugs.freedesktop.org/show_bug.cgi?id=63154

--- Comment #55 from Stephan Bergmann <sbergman@redhat.com> ---
I just notice that this clean-up involves changing occurrences of sal_uLong to
sal_uIntPtr, and I doubt that is a good idea.

The sal_uLong typedef was originally introduced to do a mass removal of
tools/solar.h's ULONG (which clashed with a Windows typedef of the same name),
without having to inspect all uses of ULONG and decide for an appropriate
replacement type in each case---those inspections could be deferred for a later
time by preserving the information about ULONG occurrences via the newly
introduced sal_uLong (which happens to be a typedef to sal_uIntPtr because that
happens to have the exact same underlying type as ULONG did).

So, occurrences of sal_uLong should not be blindly changed to sal_uIntPtr. 
(Semantically, that often does not make sense, anyway.)  They should either be
left alone or inspected to determine what other type they should actually be
changed to (likely sal_uInt32, as the comment in tools/solar.h states).

-- 
You are receiving this mail because:
You are on the CC list for the bug.