Re: LibreOffice Gerrit News for core on 2014-01-09

Hi Bjoern,

On Thu, Jan 09, 2014 at 06:00:02AM -0000, gerrit@libreoffice.org wrote:
> ~~~~ First time contributors doing great things ! ~~~~
> + upgrade liborcus
>   in https://gerrit.libreoffice.org/7310 from Markus Mohrhard
>   about module build, external, sc

This is buggy, Markus is obviously not a first time contributor. I tried
to run 'send-daily-digest' locally to fix this, but here it works fine.
With the attached patch, the output is:

> ~~~~ First time contributors doing great things! ~~~~
> + Use filelist in some packages
>   in https://gerrit.libreoffice.org/7311 from Marcos Souza
>   about module scp2
> + fdo#72563 : Pageref field tag not preserved
>   in https://gerrit.libreoffice.org/7074 from Rajashri Udhoji
>   about module sw
> ~~~~ End of freshness ~~~~

Which is still bad, as Marcos is not a first-time contributor, but
that's something I can understand, his git name is 'Marcos Paulo de
Souza', but the gerrit name is just 'Marcos Souza'.

Do you have an idea why the instance that sends the mail considers
~everyone a new contributor?

Thanks,

Miklos

diff --git a/gerritbot/send-daily-digest b/gerritbot/send-daily-digest
index 6786db3..fb2f7f5 100755
--- a/gerritbot/send-daily-digest
+++ b/gerritbot/send-daily-digest
@@ -16,7 +16,6 @@ import email.mime.text
 import json
 import os
 import subprocess
-import sh
 import smtplib
 import sys
 
@@ -66,7 +65,7 @@ def get_digest(query):
 
 
 def init_freshers():
-    repo_dir='/var/tmp/core.git'
+    repo_dir='/home/vmiklos/git/libreoffice/master/.git'
     if not os.path.exists(repo_dir):os.makedirs(repo_dir)
     os.chdir(repo_dir)
 
@@ -137,6 +136,7 @@ Your friendly LibreOffice Gerrit Digest Mailer
 
 Note: The bot generating this message can be found and improved here:
        
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest'''
+    print("debug, body is '%s'" % body)
     msg = email.mime.text.MIMEText(body, 'plain', 'UTF-8')
     msg['From'] = msg_from
     msg['To'] = msg_to[0]
@@ -146,7 +146,7 @@ Note: The bot generating this message can be found and improved here:
     msg['Reply-To'] = msg_to[0]
     msg['X-Mailer'] = 'LibreOfficeGerritDigestMailer 1.1'
 
-    server.sendmail(msg_from, msg_to, str(msg))
+    #server.sendmail(msg_from, msg_to, str(msg))
 
     return project
 
@@ -158,7 +158,7 @@ if __name__ == '__main__':
     args=vars(parser.parse_args())
     msg_from = 'gerrit@libreoffice.org'
     msg_to = ['libreoffice@lists.freedesktop.org', 'qa@fr.libreoffice.org']
-    server = smtplib.SMTP('localhost')
+    #server = smtplib.SMTP('localhost')
 
     if args['repo'] == 'all':
         send_message_for_project('core')
@@ -166,6 +166,6 @@ if __name__ == '__main__':
         send_message_for_project('dev-tools')
     else:
         send_message_for_project(args['repo'])
-    server.quit()
+    #server.quit()
 
 # vim: set et sw=4 ts=4:

Attachment: signature.asc
Description: Digital signature