Re: core.git: 2 commits - dbaccess/source

On 07/01/14 17:18, Lionel Elie Mamane wrote:

> commit 4933d0578e73130d9b06a849139934d952338155
> Author: Lionel Elie Mamane <lionel@mamane.lu>
> Date:   Sat Dec 21 10:41:51 2013 +0100
>
>     ODB ODF standard conformance: xlink:href needs xlink:type
>     
>     Change-Id: Ide0fc9331a62c1ddb1f7fe9aaee8a27ed35af8e7
>
> diff --git a/dbaccess/source/filter/xml/xmlExport.cxx b/dbaccess/source/filter/xml/xmlExport.cxx
> index f1b9350..d66ec0c 100644
> --- a/dbaccess/source/filter/xml/xmlExport.cxx
> +++ b/dbaccess/source/filter/xml/xmlExport.cxx
> @@ -651,6 +651,7 @@ void ODBExport::exportConnectionData()
>              else
>              {
>                  AddAttribute(XML_NAMESPACE_XLINK, XML_HREF,sValue);
> +                AddAttribute(XML_NAMESPACE_XLINK, XML_TYPE, XML_SIMPLE);
>                  SvXMLElementExport aElem(*this,XML_NAMESPACE_DB, XML_CONNECTION_RESOURCE, 
> sal_True, sal_True);
>              }
>          }
> @@ -861,6 +862,7 @@ void ODBExport::exportComponent(XPropertySet* _xProp)
>          sValue = "reports/" + sValue;
>  
>      AddAttribute(XML_NAMESPACE_XLINK, XML_HREF,sValue);
> +    AddAttribute(XML_NAMESPACE_DB, XML_TYPE, XML_SIMPLE);

should this not be XML_NAMESPACE_XLINK ? there is also a db:type
attribute in the schema but it doesn't have hard-coded "simple" value...

>      sal_Bool bAsTemplate = sal_False;
>      _xProp->getPropertyValue(PROPERTY_AS_TEMPLATE) >>= bAsTemplate;
>      AddAttribute(XML_NAMESPACE_DB, XML_AS_TEMPLATE,bAsTemplate ? XML_TRUE : XML_FALSE);