Re: Problems compiling LO with Visual Studio 2008

Hi Pavel,

about the SHARDAPPINFO: I run into this, too. See the attached patch, 
I'll commit this soon.

Thomas

On 31.10.2013 19:36, Pavel Laštovička wrote:
> Hi all,
>
> I am trying to compile LO 4.1.3 on my machine with Windows XP and Visual
> Studio 2008 and I have run into some problems.
> Is Visual Studio 2008 still supported? Or should I try to get a newer
> version?
>
> First problem was that build did not start at all with error in
> external/Package_msvc_dlls.mk. I think it was failing on MSVC_DLL_PATH
> being empty.
> I tried to set it to a bogus path to make build start.
> Later I got error about undefined SHARDAPPIDINFO structure. On the net I
> found MSDN mentioning the structure is available from Windows 7 up.
>
> Thanks

diff --git a/vcl/win/source/app/salinst.cxx b/vcl/win/source/app/salinst.cxx
index 22917e8..46cbbe4 100644
--- a/vcl/win/source/app/salinst.cxx
+++ b/vcl/win/source/app/salinst.cxx
@@ -1044,6 +1044,7 @@ void WinSalInstance::AddToRecentDocumentList(const OUString& rFileUrl, const 
OUS

     if (osl::FileBase::E_None == rc)
     {
+#if WINVER >= 0x0600
         if ( aSalShlData.mbW7 )
         {
             typedef HRESULT ( WINAPI *SHCREATEITEMFROMPARSINGNAME )( PCWSTR, IBindCtx*, REFIID, 
void **ppv );
@@ -1105,6 +1106,9 @@ void WinSalInstance::AddToRecentDocumentList(const OUString& rFileUrl, const 
OUS
         }
         // For whatever reason, we could not use the SHARD_APPIDINFO semantics
         SHAddToRecentDocs(SHARD_PATHW, (PCWSTR) system_path.getStr());
+#else
+        (void) rDocumentService;
+#endif
     }
 }