Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


On 10/31/2013 09:46 AM, Noel Grandin wrote:
There are some odd macros here:

    http://opengrok.libreoffice.org/xref/core/sal/rtl/string.cxx#58

which look like:

      #define IMPL_RTL_STRINGNAME( n )    rtl_string_ ## n

and then they are used in the code like this:

     IMPL_RTL_STRINGNAME( release )( *pTarget );

and in methods definitions like this:

     static IMPL_RTL_STRINGDATA* IMPL_RTL_STRINGNAME( ImplAlloc )(
sal_Int32 nLen )


I'm not seeing the points of these macros?
They make the methods in questions invisible to OpenGrok and grep and
they don't seem to add any value.

Those IMPL_RTL_* macros are for use in the #include "strtmpl.cxx" a few lines further down. Sort of poor man's templates, to do code sharing among string.cxx and ustring.cxx.

Uses of the macros directly in string.cxx could be resolved, of course.

Stephan

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.