Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi Tushar,

On Fri, Oct 25, 2013 at 04:10:35PM +0530, Tushar Bende <tushar.bende@synerzip.com> wrote:
I observed that while running* make CppunitTest_sw_ooxmlexport*  some test
cases are executed twice.(to be precise 61 out of 75 test cases)
I checked code for root cause and observed that it is because of below code
in *ooxmlexport.cxx line 254*
*
*
    for (unsigned int i = 0; i < SAL_N_ELEMENTS(aMethods); ++i)
    {
        MethodEntry<Test>& rEntry = aMethods[i];
        load("/sw/qa/extras/ooxmlexport/data/", rEntry.pName);
        // If the testcase is stored in some other format, it's pointless
to test.
        if (OString(rEntry.pName).endsWith(".docx") &&
std::find(vBlacklist.begin(), vBlacklist.end(), rEntry.pName) ==
vBlacklist.end())
          *  (this->*rEntry.pMethod)();*
        reload("Office Open XML Text");
       * (this->*rEntry.pMethod)();*
        finish();
    }

basically it is executing test case twice if
(OString(rEntry.pName).endsWith(".docx") && std::find(vBlacklist.begin(),
vBlacklist.end(), rEntry.pName) == vBlacklist.end()) condition is true.
Please let me know what should be done.

Yes, that's intentional. See here for rationale:

http://opengrok.libreoffice.org/xref/core/sw/qa/extras/README#18

If that causes a problem, then there is probably some bug in the
import/export filter.

Miklos

Attachment: signature.asc
Description: Digital signature


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.