Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


https://bugs.freedesktop.org/show_bug.cgi?id=54938

--- Comment #12 from Marcos Souza <marcos.souza.org@gmail.com> ---
I saw a lot of places like this:

sal_Bool SAL_CALL ScTabViewObj::supportsService( const OUString& rServiceName )
                                                   
throw(uno::RuntimeException)
{
    return rServiceName.equalsAscii( SCTABVIEWOBJ_SERVICE ) || 
           rServiceName.equalsAscii( SCVIEWSETTINGS_SERVICE );
}

So, can we just exchange this to cppu::supportsService? Or we need to some
another pieces of code?

OBS: I believe all places that test the supportsService like this have this
same function:
uno::Sequence<OUString> SAL_CALL ScTabViewObj::getSupportedServiceNames()
                                                   
throw(uno::RuntimeException)
{
    uno::Sequence<OUString> aRet(2);
    OUString* pArray = aRet.getArray();
    pArray[0] = OUString( SCTABVIEWOBJ_SERVICE );
    pArray[1] = OUString( SCVIEWSETTINGS_SERVICE );
    return aRet;
}

with the same service name added into uno::Sequence.

With this change we can have a more standard code, at least talking about the
way we get uno service names :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.