Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


https://bugs.freedesktop.org/show_bug.cgi?id=54938

--- Comment #7 from Stephan Bergmann <sbergman@redhat.com> ---
(In reply to comment #5)
In reportdesign, I saw a lot of uses of comhelper::existsValue:

::sal_Bool SAL_CALL OToolboxController::supportsService( const OUString&
ServiceName ) throw (uno::RuntimeException)
{
    return
::comphelper::existsValue(ServiceName,getSupportedServiceNames_Static());
}

We want to remove this too and use cppuhelper::supportsService?

Yes, I would suggest to rewrite those supportsService member functions to use
cppuhelper::supportsService, for the sake of consistency.

(In reply to comment #6)
sal_Bool SAL_CALL ServiceInfoHelper::supportsService( const OUString&
ServiceName, const ::com::sun::star::uno::Sequence< OUString >&
SupportedServices ) throw() 
{
    const OUString * pArray = SupportedServices.getConstArray();
    for( sal_Int32 i = 0; i < SupportedServices.getLength(); i++ )
        if( pArray[i] == ServiceName )
            return sal_True;
    return sal_False;
}

Maybe we want to remove this too?

Yes, the static comphelper::ServiceInfoHelper::supportsService can go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.