Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


On 09/10/13 16:25, Miklos Vajna wrote:
On Wed, Oct 09, 2013 at 03:01:02PM +0200, Stephan Bergmann <sbergman@redhat.com> wrote:
Just curious, but at least in general there's nothing in our code
base to imply "OSX" means "without unit tests."

I was speaking about the Writer filter tests. Those are Linux-only, e.g.:

http://opengrok.libreoffice.org/xref/core/sw/qa/extras/odfimport/odfimport.cxx#43

IIRC the reason for that is --headless not really working on
Windows/Mac, or something like that. I would be glad to remove those
ifdefs, but if the cost is that some tinderbox owners shut their
instance down because of this change, then better not.

IMHO this disabling of tests based on OS needs to end.

it would be much better to have a configure option
--disable-annoying-tests or whatever so that those who need it can use
it and those who don't can run the tests on any OS.

or perhaps move those tests to subsequentcheck where the other annoying
JUnitTests are.

or actually iirc the PythonTest somehow manages not to pop up any
windows on Windows, perhaps whatever secret it's using to achieve that
could be used elsewhere too.




Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.