dubious code in dbaccess/source/core/api/KeySet.cxx?

Stephan Bergmann <sbergman -AT- redhat.com>

Wed, 02 Oct 2013 18:28:39 +0200

OKeySet::deleteRows in dbaccess/source/core/api/KeySet.cxx contains the loop

    for(;pBegin != pEnd;++pBegin)
    {
        aSql.append(sCon + aOr);
    }

that appends the exact same text to aSql (pEnd-pBegin) number of times,

which---at least to an SQL-ignoramus---looks dubious. (On the other

hand, the code appears to be effectively like that since the beginning.)

Stephan

Context

dubious code in dbaccess/source/core/api/KeySet.cxx? · Stephan Bergmann

Re: dubious code in dbaccess/source/core/api/KeySet.cxx? · Lionel Elie Mamane

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.