Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index 

On Tue, 2013-08-13 at 11:36 +0200, Zolnai Tamás wrote:

Hi Caolán,

I founnd a problem with your commit:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=f41e7c704898fa0e86d6d128f5bd28f37c081e92

When I try to modify a character style Writer crashes.
After a bit debug I found that your commit changed SwDocShell::Edit()
(in docst.cxx) method sixth parameter from sal_uInt16 to OString but
at docst.cxx:448 this Edit method is called with 0 as sixth parameter,
which haven't sense in the new context but interpreted as an
rtl_String null pointer and used to call OString constructor, which
can't handle null pointers so Writer crashes.


Yeah, that's right. I noticed that myself eventually and it should be
fixed now. Probably should have read my mail earlier and saved myself
the hassle :-)

C.

Context

Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.