Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I would like you to review the following patch:

    https://gerrit.libreoffice.org/5421

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/5421/1

Help button added to the aboutconfigvalue dialog

Change-Id: Id47fafe67c20de5b163f7a4a04d2475297664c54
---
M cui/source/options/optaboutconfig.cxx
M cui/source/options/optaboutconfig.hxx
M cui/uiconfig/ui/aboutconfigvaluedialog.ui
3 files changed, 15 insertions(+), 5 deletions(-)



diff --git a/cui/source/options/optaboutconfig.cxx b/cui/source/options/optaboutconfig.cxx
index 30b79d8..2e9c670 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -335,8 +335,6 @@
 CuiAboutConfigValueDialog::CuiAboutConfigValueDialog( Window* pWindow, const OUString& rValue )
     :ModalDialog( pWindow, "AboutConfigValueDialog", "cui/ui/aboutconfigvaluedialog.ui" )
 {
-    get(m_pBtnOK, "ok");
-    get(m_pBtnCancel, "cancel");
     get(m_pEDValue, "valuebox");
 
     m_pEDValue->SetText( rValue );
diff --git a/cui/source/options/optaboutconfig.hxx b/cui/source/options/optaboutconfig.hxx
index df1a84c..f2d6335 100644
--- a/cui/source/options/optaboutconfig.hxx
+++ b/cui/source/options/optaboutconfig.hxx
@@ -57,9 +57,6 @@
 class CuiAboutConfigValueDialog : public ModalDialog
 {
 private:
-    OKButton*            m_pBtnOK;
-    CancelButton*        m_pBtnCancel;
-
     VclMultiLineEdit*    m_pEDValue;
 
 public:
diff --git a/cui/uiconfig/ui/aboutconfigvaluedialog.ui b/cui/uiconfig/ui/aboutconfigvaluedialog.ui
index deeab7a..b00c062 100644
--- a/cui/uiconfig/ui/aboutconfigvaluedialog.ui
+++ b/cui/uiconfig/ui/aboutconfigvaluedialog.ui
@@ -45,6 +45,20 @@
                 <property name="position">1</property>
               </packing>
             </child>
+            <child>
+              <object class="GtkButton" id="help">
+                <property name="label">gtk-help</property>
+                <property name="visible">True</property>
+                <property name="can_focus">True</property>
+                <property name="receives_default">True</property>
+                <property name="use_stock">True</property>
+              </object>
+              <packing>
+                <property name="expand">False</property>
+                <property name="fill">True</property>
+                <property name="position">2</property>
+              </packing>
+            </child>
           </object>
           <packing>
             <property name="expand">False</property>
@@ -98,6 +112,7 @@
     <action-widgets>
       <action-widget response="0">ok</action-widget>
       <action-widget response="0">cancel</action-widget>
+      <action-widget response="0">help</action-widget>
     </action-widgets>
   </object>
 </interface>

-- 
To view, visit https://gerrit.libreoffice.org/5421
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id47fafe67c20de5b163f7a4a04d2475297664c54
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Efe Gürkan Yalaman <efeyalaman@gmail.com>
Gerrit-Reviewer: LibreOffice gerrit bot <gerrit@libreoffice.org>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.