Date: prev next · Thread: first prev next last
2013 Archives by date, by thread · List index


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/4979

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/gerrit-etc refs/changes/79/4979/1

Avoid confusing wording in mails requesting a review

Given that NewChange.vm is not only used when user A uploads his changeset
(with "From: A (via Code Review)"), but also when user B later adds user C to
that changeset's list of reviewers (with "From: B (via Code Review)"), the
words "I have submitted a patch for review" are misleading.  The new wording is
closer to that in mail/NewChange.vm.example, but hopefully still friendly
enough.

Change-Id: I37cc7801716b43693a2f14d28fc5c410b01d95d9
---
M mail/NewChange.vm
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/mail/NewChange.vm b/mail/NewChange.vm
index 34af52f..7608bee 100644
--- a/mail/NewChange.vm
+++ b/mail/NewChange.vm
@@ -34,7 +34,7 @@
 ##
 Hi,
 
-I have submitted a patch for review:
+I would like you to review the following patch:
 
     $email.changeUrl
 

-- 
To view, visit https://gerrit.libreoffice.org/4979
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I37cc7801716b43693a2f14d28fc5c410b01d95d9
Gerrit-PatchSet: 1
Gerrit-Project: gerrit-etc
Gerrit-Branch: prod
Gerrit-Owner: Norbert Thiebaud <nthiebaud@gmail.com>
Gerrit-Reviewer: Stephan Bergmann <sbergman@redhat.com>


Context


Privacy Policy | Impressum (Legal Info) | Copyright information: Unless otherwise specified, all text and images on this website are licensed under the Creative Commons Attribution-Share Alike 3.0 License. This does not include the source code of LibreOffice, which is licensed under the Mozilla Public License (MPLv2). "LibreOffice" and "The Document Foundation" are registered trademarks of their corresponding registered owners or are in actual use as trademarks in one or more countries. Their respective logos and icons are also subject to international copyright laws. Use thereof is explained in our trademark policy.